Skip to content

Commit

Permalink
fbdev/core: Remove empty internal helpers from fb_logo.c
Browse files Browse the repository at this point in the history
Remove the two empty helpers for the case the CONFIG_FB_LOGO_EXTRA
has not been set. They are internal functions and only called once.
Providing empty replacements seems like overkill. Instead protect
the call sites with a test for CONFIG_FB_LOGO_EXTRA.

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Acked-by: Javier Martinez Canillas <javierm@redhat.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20230907085408.9354-7-tzimmermann@suse.de
  • Loading branch information
Thomas Zimmermann committed Sep 11, 2023
1 parent 8887086 commit 9ab7dc2
Showing 1 changed file with 6 additions and 16 deletions.
22 changes: 6 additions & 16 deletions drivers/video/fbdev/core/fb_logo.c
Original file line number Diff line number Diff line change
Expand Up @@ -413,21 +413,6 @@ static int fb_show_extra_logos(struct fb_info *info, int y, int rotate)

return y;
}

#else /* !CONFIG_FB_LOGO_EXTRA */

static inline int fb_prepare_extra_logos(struct fb_info *info,
unsigned int height,
unsigned int yres)
{
return height;
}

static inline int fb_show_extra_logos(struct fb_info *info, int y, int rotate)
{
return y;
}

#endif /* CONFIG_FB_LOGO_EXTRA */

int fb_prepare_logo(struct fb_info *info, int rotate)
Expand Down Expand Up @@ -498,8 +483,11 @@ int fb_prepare_logo(struct fb_info *info, int rotate)
height = fb_logo.logo->height;
if (fb_center_logo)
height += (yres - fb_logo.logo->height) / 2;
#ifdef CONFIG_FB_LOGO_EXTRA
height = fb_prepare_extra_logos(info, height, yres);
#endif

return fb_prepare_extra_logos(info, height, yres);
return height;
}

int fb_show_logo(struct fb_info *info, int rotate)
Expand All @@ -512,7 +500,9 @@ int fb_show_logo(struct fb_info *info, int rotate)

count = fb_logo_count < 0 ? num_online_cpus() : fb_logo_count;
y = fb_show_logo_line(info, rotate, fb_logo.logo, 0, count);
#ifdef CONFIG_FB_LOGO_EXTRA
y = fb_show_extra_logos(info, y, rotate);
#endif

return y;
}

0 comments on commit 9ab7dc2

Please sign in to comment.