Skip to content

Commit

Permalink
iwlwifi: iwl_mvm_tx_mpdu() must be called with BH disabled
Browse files Browse the repository at this point in the history
As iwl_mvm_tx_mpdu() is not disabling BH while obtaining iwl_mvm_sta->lock
(which is being taken from BH context as well), it has to be always
invoked with BH disabled. Make that clear in a comment.

Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
  • Loading branch information
Jiri Kosina authored and Luca Coelho committed Jun 29, 2019
1 parent b741422 commit 9ae3b87
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion drivers/net/wireless/intel/iwlwifi/mvm/tx.c
Original file line number Diff line number Diff line change
Expand Up @@ -1063,7 +1063,9 @@ static int iwl_mvm_tx_pkt_queued(struct iwl_mvm *mvm,
}

/*
* Sets the fields in the Tx cmd that are crypto related
* Sets the fields in the Tx cmd that are crypto related.
*
* This function must be called with BHs disabled.
*/
static int iwl_mvm_tx_mpdu(struct iwl_mvm *mvm, struct sk_buff *skb,
struct ieee80211_tx_info *info,
Expand Down

0 comments on commit 9ae3b87

Please sign in to comment.