Skip to content

Commit

Permalink
rxrpc: Don't send an ACK at the end of service call response transmis…
Browse files Browse the repository at this point in the history
…sion

Don't send an IDLE ACK at the end of the transmission of the response to a
service call.  The service end resends DATA packets until the client sends an
ACK that hard-acks all the send data.  At that point, the call is complete.

Signed-off-by: David Howells <dhowells@redhat.com>
  • Loading branch information
David Howells committed Sep 23, 2016
1 parent b24d289 commit 9aff212
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions net/rxrpc/recvmsg.c
Original file line number Diff line number Diff line change
Expand Up @@ -143,8 +143,6 @@ static void rxrpc_end_rx_phase(struct rxrpc_call *call)
if (call->state == RXRPC_CALL_CLIENT_RECV_REPLY) {
rxrpc_propose_ACK(call, RXRPC_ACK_IDLE, 0, 0, true, false);
rxrpc_send_call_packet(call, RXRPC_PACKET_TYPE_ACK);
} else {
rxrpc_propose_ACK(call, RXRPC_ACK_IDLE, 0, 0, false, false);
}

write_lock_bh(&call->state_lock);
Expand Down

0 comments on commit 9aff212

Please sign in to comment.