Skip to content

Commit

Permalink
xfs: Fix missing xfs_iunlock() on error recovery path in xfs_readlink()
Browse files Browse the repository at this point in the history
Commit b52a360 forgot to call xfs_iunlock() when it detected corrupted
symplink and bailed out. Fix it by jumping to 'out' instead of doing return.

CC: stable@kernel.org
CC: Carlos Maiolino <cmaiolino@redhat.com>
Signed-off-by: Jan Kara <jack@suse.cz>
Reviewed-by: Alex Elder <elder@kernel.org>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
Signed-off-by: Ben Myers <bpm@sgi.com>
  • Loading branch information
Jan Kara authored and Ben Myers committed Jan 25, 2012
1 parent dcd6c92 commit 9b025eb
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion fs/xfs/xfs_vnodeops.c
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,8 @@ xfs_readlink(
__func__, (unsigned long long) ip->i_ino,
(long long) pathlen);
ASSERT(0);
return XFS_ERROR(EFSCORRUPTED);
error = XFS_ERROR(EFSCORRUPTED);
goto out;
}


Expand Down

0 comments on commit 9b025eb

Please sign in to comment.