Skip to content

Commit

Permalink
RDMA/cma: Remove unneeded qp_type parameter from rdma_cm
Browse files Browse the repository at this point in the history
The qp_type parameter into the rdma_cm is unneeded, and can be
misleading.  The QP type should be determined from the port space.

Signed-off-by: Sean Hefty <sean.hefty@intel.com>
Signed-off-by: Roland Dreier <rolandd@cisco.com>
  • Loading branch information
Sean Hefty authored and Roland Dreier committed Dec 12, 2006
1 parent 0a1336c commit 9b2e9c0
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 6 deletions.
6 changes: 1 addition & 5 deletions drivers/infiniband/core/cma.c
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,6 @@ struct rdma_id_private {

u32 seq_num;
u32 qp_num;
enum ib_qp_type qp_type;
u8 srq;
};

Expand Down Expand Up @@ -392,7 +391,6 @@ int rdma_create_qp(struct rdma_cm_id *id, struct ib_pd *pd,

id->qp = qp;
id_priv->qp_num = qp->qp_num;
id_priv->qp_type = qp->qp_type;
id_priv->srq = (qp->srq != NULL);
return 0;
err:
Expand Down Expand Up @@ -1860,7 +1858,7 @@ static int cma_connect_ib(struct rdma_id_private *id_priv,
req.service_id = cma_get_service_id(id_priv->id.ps,
&route->addr.dst_addr);
req.qp_num = id_priv->qp_num;
req.qp_type = id_priv->qp_type;
req.qp_type = IB_QPT_RC;
req.starting_psn = id_priv->seq_num;
req.responder_resources = conn_param->responder_resources;
req.initiator_depth = conn_param->initiator_depth;
Expand Down Expand Up @@ -1937,7 +1935,6 @@ int rdma_connect(struct rdma_cm_id *id, struct rdma_conn_param *conn_param)

if (!id->qp) {
id_priv->qp_num = conn_param->qp_num;
id_priv->qp_type = conn_param->qp_type;
id_priv->srq = conn_param->srq;
}

Expand Down Expand Up @@ -2021,7 +2018,6 @@ int rdma_accept(struct rdma_cm_id *id, struct rdma_conn_param *conn_param)

if (!id->qp && conn_param) {
id_priv->qp_num = conn_param->qp_num;
id_priv->qp_type = conn_param->qp_type;
id_priv->srq = conn_param->srq;
}

Expand Down
1 change: 0 additions & 1 deletion include/rdma/rdma_cm.h
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,6 @@ struct rdma_conn_param {
/* Fields below ignored if a QP is created on the rdma_cm_id. */
u8 srq;
u32 qp_num;
enum ib_qp_type qp_type;
};

/**
Expand Down

0 comments on commit 9b2e9c0

Please sign in to comment.