Skip to content

Commit

Permalink
drm/i915: Use atomic state when changing cursor visibility.
Browse files Browse the repository at this point in the history
Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
  • Loading branch information
Maarten Lankhorst authored and Daniel Vetter committed Sep 10, 2015
1 parent 11c22da commit 9b4101b
Showing 1 changed file with 7 additions and 6 deletions.
13 changes: 7 additions & 6 deletions drivers/gpu/drm/i915/intel_display.c
Original file line number Diff line number Diff line change
Expand Up @@ -9916,8 +9916,9 @@ static void intel_crtc_update_cursor(struct drm_crtc *crtc,
struct drm_i915_private *dev_priv = dev->dev_private;
struct intel_crtc *intel_crtc = to_intel_crtc(crtc);
int pipe = intel_crtc->pipe;
int x = crtc->cursor_x;
int y = crtc->cursor_y;
struct drm_plane_state *cursor_state = crtc->cursor->state;
int x = cursor_state->crtc_x;
int y = cursor_state->crtc_y;
u32 base = 0, pos = 0;

if (on)
Expand All @@ -9930,7 +9931,7 @@ static void intel_crtc_update_cursor(struct drm_crtc *crtc,
base = 0;

if (x < 0) {
if (x + intel_crtc->base.cursor->state->crtc_w <= 0)
if (x + cursor_state->crtc_w <= 0)
base = 0;

pos |= CURSOR_POS_SIGN << CURSOR_X_SHIFT;
Expand All @@ -9939,7 +9940,7 @@ static void intel_crtc_update_cursor(struct drm_crtc *crtc,
pos |= x << CURSOR_X_SHIFT;

if (y < 0) {
if (y + intel_crtc->base.cursor->state->crtc_h <= 0)
if (y + cursor_state->crtc_h <= 0)
base = 0;

pos |= CURSOR_POS_SIGN << CURSOR_Y_SHIFT;
Expand All @@ -9955,8 +9956,8 @@ static void intel_crtc_update_cursor(struct drm_crtc *crtc,
/* ILK+ do this automagically */
if (HAS_GMCH_DISPLAY(dev) &&
crtc->cursor->state->rotation == BIT(DRM_ROTATE_180)) {
base += (intel_crtc->base.cursor->state->crtc_h *
intel_crtc->base.cursor->state->crtc_w - 1) * 4;
base += (cursor_state->crtc_h *
cursor_state->crtc_w - 1) * 4;
}

if (IS_845G(dev) || IS_I865G(dev))
Expand Down

0 comments on commit 9b4101b

Please sign in to comment.