Skip to content

Commit

Permalink
ASoC: pxa: Remove superfluous locking
Browse files Browse the repository at this point in the history
The locking here was added in commit 71a2956 ("ASoC: Lock the CODEC in PXA
external jack controls") to protect the DAPM changes that are made inside of
${board}_ext_control() against concurrent updates. The ASoC core was updated in
commit a73fb2d ("ASoC: dapm: Use DAPM mutex for DAPM ops instead of codec
mutex") to use a card wide lock rather the CODEC mutex to protect DAPM
operations. We now have proper locking inside ${board}_ext_control() itself, so
taking the CODEC lock can be removed.

Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Mark Brown <broonie@linaro.org>
  • Loading branch information
Lars-Peter Clausen authored and Mark Brown committed Feb 23, 2014
1 parent 38dbfb5 commit 9b87a5b
Show file tree
Hide file tree
Showing 5 changed files with 0 additions and 20 deletions.
4 changes: 0 additions & 4 deletions sound/soc/pxa/corgi.c
Original file line number Diff line number Diff line change
Expand Up @@ -99,13 +99,9 @@ static int corgi_startup(struct snd_pcm_substream *substream)
struct snd_soc_pcm_runtime *rtd = substream->private_data;
struct snd_soc_codec *codec = rtd->codec;

mutex_lock(&codec->mutex);

/* check the jack status at stream startup */
corgi_ext_control(&codec->dapm);

mutex_unlock(&codec->mutex);

return 0;
}

Expand Down
4 changes: 0 additions & 4 deletions sound/soc/pxa/magician.c
Original file line number Diff line number Diff line change
Expand Up @@ -73,13 +73,9 @@ static int magician_startup(struct snd_pcm_substream *substream)
struct snd_soc_pcm_runtime *rtd = substream->private_data;
struct snd_soc_codec *codec = rtd->codec;

mutex_lock(&codec->mutex);

/* check the jack status at stream startup */
magician_ext_control(codec);

mutex_unlock(&codec->mutex);

return 0;
}

Expand Down
4 changes: 0 additions & 4 deletions sound/soc/pxa/poodle.c
Original file line number Diff line number Diff line change
Expand Up @@ -76,13 +76,9 @@ static int poodle_startup(struct snd_pcm_substream *substream)
struct snd_soc_pcm_runtime *rtd = substream->private_data;
struct snd_soc_codec *codec = rtd->codec;

mutex_lock(&codec->mutex);

/* check the jack status at stream startup */
poodle_ext_control(&codec->dapm);

mutex_unlock(&codec->mutex);

return 0;
}

Expand Down
4 changes: 0 additions & 4 deletions sound/soc/pxa/spitz.c
Original file line number Diff line number Diff line change
Expand Up @@ -108,13 +108,9 @@ static int spitz_startup(struct snd_pcm_substream *substream)
struct snd_soc_pcm_runtime *rtd = substream->private_data;
struct snd_soc_codec *codec = rtd->codec;

mutex_lock(&codec->mutex);

/* check the jack status at stream startup */
spitz_ext_control(&codec->dapm);

mutex_unlock(&codec->mutex);

return 0;
}

Expand Down
4 changes: 0 additions & 4 deletions sound/soc/pxa/tosa.c
Original file line number Diff line number Diff line change
Expand Up @@ -80,13 +80,9 @@ static int tosa_startup(struct snd_pcm_substream *substream)
struct snd_soc_pcm_runtime *rtd = substream->private_data;
struct snd_soc_codec *codec = rtd->codec;

mutex_lock(&codec->mutex);

/* check the jack status at stream startup */
tosa_ext_control(codec);

mutex_unlock(&codec->mutex);

return 0;
}

Expand Down

0 comments on commit 9b87a5b

Please sign in to comment.