Skip to content

Commit

Permalink
Merge tag 'spi-fix-v5.15-rc1' of git://git.kernel.org/pub/scm/linux/k…
Browse files Browse the repository at this point in the history
…ernel/git/broonie/spi

Pull spi modalias fix from Mark Brown:
 "Fix modalias issues

  As reported by Russell King the change to use OF style modaliases for
  DT enumerated broke at least the spi-nor driver, the patch here
  reverts that change to fix the regression.

  Sadly this will mean that anything that started loading since the
  change to OF modaliases will run into issues, there doesn't seem to be
  any approach which doesn't cause some problems and thi seems like the
  least bad approach - gory details are in the commit log for the
  change.

  I'm currently working through the SPI drivers to add ID tables and
  missing IDs to tables which should address things from the other end,
  this seems more straightforward and robust than any other options"

* tag 'spi-fix-v5.15-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi:
  spi: Revert modalias changes
  • Loading branch information
Linus Torvalds committed Sep 22, 2021
2 parents cf1d2c3 + 96c8395 commit 9bedf10
Showing 1 changed file with 0 additions and 8 deletions.
8 changes: 0 additions & 8 deletions drivers/spi/spi.c
Original file line number Diff line number Diff line change
Expand Up @@ -58,10 +58,6 @@ modalias_show(struct device *dev, struct device_attribute *a, char *buf)
const struct spi_device *spi = to_spi_device(dev);
int len;

len = of_device_modalias(dev, buf, PAGE_SIZE);
if (len != -ENODEV)
return len;

len = acpi_device_modalias(dev, buf, PAGE_SIZE - 1);
if (len != -ENODEV)
return len;
Expand Down Expand Up @@ -367,10 +363,6 @@ static int spi_uevent(struct device *dev, struct kobj_uevent_env *env)
const struct spi_device *spi = to_spi_device(dev);
int rc;

rc = of_device_uevent_modalias(dev, env);
if (rc != -ENODEV)
return rc;

rc = acpi_device_uevent_modalias(dev, env);
if (rc != -ENODEV)
return rc;
Expand Down

0 comments on commit 9bedf10

Please sign in to comment.