Skip to content

Commit

Permalink
net: qrtr: ns: Return 0 if server port is not present
Browse files Browse the repository at this point in the history
When a 'DEL_CLIENT' message is received from the remote, the corresponding
server port gets deleted. A DEL_SERVER message is then announced for this
server. As part of handling the subsequent DEL_SERVER message, the name-
server attempts to delete the server port which results in a '-ENOENT' error.
The return value from server_del() is then propagated back to qrtr_ns_worker,
causing excessive error prints.
To address this, return 0 from control_cmd_del_server() without checking the
return value of server_del(), since the above scenario is not an error case
and hence server_del() doesn't have any other error return value.

Signed-off-by: Sarannya Sasikumar <quic_sarannya@quicinc.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Sarannya S authored and David S. Miller committed Jan 1, 2024
1 parent 82585d5 commit 9bf2e91
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion net/qrtr/ns.c
Original file line number Diff line number Diff line change
Expand Up @@ -512,7 +512,9 @@ static int ctrl_cmd_del_server(struct sockaddr_qrtr *from,
if (!node)
return -ENOENT;

return server_del(node, port, true);
server_del(node, port, true);

return 0;
}

static int ctrl_cmd_new_lookup(struct sockaddr_qrtr *from,
Expand Down

0 comments on commit 9bf2e91

Please sign in to comment.