Skip to content

Commit

Permalink
powerpc/cell: Move controller ops from ppc_md to controller_ops
Browse files Browse the repository at this point in the history
This moves the Cell platform to use the pci_controller_ops
structure rather than ppc_md for PCI controller operations.

Signed-off-by: Daniel Axtens <dja@axtens.net>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
  • Loading branch information
Daniel Axtens authored and Michael Ellerman committed Apr 11, 2015
1 parent 97884e0 commit 9c1368f
Show file tree
Hide file tree
Showing 3 changed files with 33 additions and 3 deletions.
24 changes: 24 additions & 0 deletions arch/powerpc/platforms/cell/cell.h
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
/*
* Cell Platform common data structures
*
* Copyright 2015, Daniel Axtens, IBM Corporation
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; either version 2, or (at your option)
* any later version.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*/

#ifndef CELL_H
#define CELL_H

#include <asm/pci-bridge.h>

extern struct pci_controller_ops cell_pci_controller_ops;

#endif
7 changes: 4 additions & 3 deletions arch/powerpc/platforms/cell/iommu.c
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@
#include <asm/firmware.h>
#include <asm/cell-regs.h>

#include "cell.h"
#include "interrupt.h"

/* Define CELL_IOMMU_REAL_UNMAP to actually unmap non-used pages
Expand Down Expand Up @@ -857,7 +858,7 @@ static int __init cell_iommu_init_disabled(void)
cell_dma_direct_offset += base;

if (cell_dma_direct_offset != 0)
ppc_md.pci_dma_dev_setup = cell_pci_dma_dev_setup;
cell_pci_controller_ops.dma_dev_setup = cell_pci_dma_dev_setup;

printk("iommu: disabled, direct DMA offset is 0x%lx\n",
cell_dma_direct_offset);
Expand Down Expand Up @@ -1197,8 +1198,8 @@ static int __init cell_iommu_init(void)
if (cell_iommu_init_disabled() == 0)
goto bail;

/* Setup various ppc_md. callbacks */
ppc_md.pci_dma_dev_setup = cell_pci_dma_dev_setup;
/* Setup various callbacks */
cell_pci_controller_ops.dma_dev_setup = cell_pci_dma_dev_setup;
ppc_md.dma_get_required_mask = cell_dma_get_required_mask;
ppc_md.tce_build = tce_build_cell;
ppc_md.tce_free = tce_free_cell;
Expand Down
5 changes: 5 additions & 0 deletions arch/powerpc/platforms/cell/setup.c
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@
#include <asm/cell-regs.h>
#include <asm/io-workarounds.h>

#include "cell.h"
#include "interrupt.h"
#include "pervasive.h"
#include "ras.h"
Expand Down Expand Up @@ -131,6 +132,8 @@ static int cell_setup_phb(struct pci_controller *phb)
if (model == NULL || strcmp(np->name, "pci"))
return 0;

phb->controller_ops = cell_pci_controller_ops;

/* Setup workarounds for spider */
if (strcmp(model, "Spider"))
return 0;
Expand Down Expand Up @@ -279,3 +282,5 @@ define_machine(cell) {
.init_IRQ = cell_init_irq,
.pci_setup_phb = cell_setup_phb,
};

struct pci_controller_ops cell_pci_controller_ops;

0 comments on commit 9c1368f

Please sign in to comment.