Skip to content

Commit

Permalink
livepatch: Use kallsyms_on_each_match_symbol() to improve performance
Browse files Browse the repository at this point in the history
Based on the test results of kallsyms_on_each_match_symbol() and
kallsyms_on_each_symbol(), the average performance can be improved by
more than 1500 times.

Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
  • Loading branch information
Zhen Lei authored and Luis Chamberlain committed Nov 13, 2022
1 parent 4dc533e commit 9cb3735
Showing 1 changed file with 19 additions and 1 deletion.
20 changes: 19 additions & 1 deletion kernel/livepatch/core.c
Original file line number Diff line number Diff line change
Expand Up @@ -153,6 +153,24 @@ static int klp_find_callback(void *data, const char *name,
return 0;
}

static int klp_match_callback(void *data, unsigned long addr)
{
struct klp_find_arg *args = data;

args->addr = addr;
args->count++;

/*
* Finish the search when the symbol is found for the desired position
* or the position is not defined for a non-unique symbol.
*/
if ((args->pos && (args->count == args->pos)) ||
(!args->pos && (args->count > 1)))
return 1;

return 0;
}

static int klp_find_object_symbol(const char *objname, const char *name,
unsigned long sympos, unsigned long *addr)
{
Expand All @@ -167,7 +185,7 @@ static int klp_find_object_symbol(const char *objname, const char *name,
if (objname)
module_kallsyms_on_each_symbol(klp_find_callback, &args);
else
kallsyms_on_each_symbol(klp_find_callback, &args);
kallsyms_on_each_match_symbol(klp_match_callback, name, &args);

/*
* Ensure an address was found. If sympos is 0, ensure symbol is unique;
Expand Down

0 comments on commit 9cb3735

Please sign in to comment.