Skip to content

Commit

Permalink
ide: ensure that we re-run the queue handler
Browse files Browse the repository at this point in the history
The conversion to blk_delay_queue() missed parts of IDE.
Add a blk_delay_queue() to ensure that the request handler
gets reinvoked when it needs to.

Note that in all but one place the old plug re-run delay of
3 msecs is used, even though it probably could be shorter
for performance reasons in some of those cases.

Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: Jens Axboe <jaxboe@fusionio.com>
  • Loading branch information
Jens Axboe committed Mar 26, 2011
1 parent 4047185 commit 9ced0b9
Showing 1 changed file with 11 additions and 1 deletion.
12 changes: 11 additions & 1 deletion drivers/ide/ide-io.c
Original file line number Diff line number Diff line change
Expand Up @@ -440,6 +440,7 @@ void do_ide_request(struct request_queue *q)
struct ide_host *host = hwif->host;
struct request *rq = NULL;
ide_startstop_t startstop;
unsigned long queue_run_ms = 3; /* old plug delay */

spin_unlock_irq(q->queue_lock);

Expand All @@ -459,6 +460,9 @@ void do_ide_request(struct request_queue *q)
prev_port = hwif->host->cur_port;
if (drive->dev_flags & IDE_DFLAG_SLEEPING &&
time_after(drive->sleep, jiffies)) {
unsigned long left = jiffies - drive->sleep;

queue_run_ms = jiffies_to_msecs(left + 1);
ide_unlock_port(hwif);
goto plug_device;
}
Expand Down Expand Up @@ -547,8 +551,10 @@ void do_ide_request(struct request_queue *q)
plug_device_2:
spin_lock_irq(q->queue_lock);

if (rq)
if (rq) {
blk_requeue_request(q, rq);
blk_delay_queue(q, queue_run_ms);
}
}

void ide_requeue_and_plug(ide_drive_t *drive, struct request *rq)
Expand All @@ -562,6 +568,10 @@ void ide_requeue_and_plug(ide_drive_t *drive, struct request *rq)
blk_requeue_request(q, rq);

spin_unlock_irqrestore(q->queue_lock, flags);

/* Use 3ms as that was the old plug delay */
if (rq)
blk_delay_queue(q, 3);
}

static int drive_is_ready(ide_drive_t *drive)
Expand Down

0 comments on commit 9ced0b9

Please sign in to comment.