Skip to content

Commit

Permalink
dt-bindings: net: qcom,ipa: remove an unnecessary restriction
Browse files Browse the repository at this point in the history
Commit d8604b2 ("dt-bindings: net: qcom,ipa: add firmware-name
property") added a requirement for a "firmware-name" property that
is more restrictive than necessary.

If the AP loads GSI firmware, the name of the firmware file to use
may optionally be provided via a "firmware-name" property.  If the
*modem* loads GSI firmware, "firmware-name" doesn't need to be
supplied--but it's harmless to do so (it will simply be ignored).

Remove the unnecessary restriction, and allow "firware-name" to be
supplied even if it's not needed.

Signed-off-by: Alex Elder <elder@linaro.org>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
  • Loading branch information
Alex Elder authored and Jakub Kicinski committed Nov 12, 2022
1 parent 45f22f2 commit 9d26628
Showing 1 changed file with 0 additions and 10 deletions.
10 changes: 0 additions & 10 deletions Documentation/devicetree/bindings/net/qcom,ipa.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -162,16 +162,6 @@ oneOf:
- required:
- memory-region

# If memory-region is present, firmware-name may optionally be present.
# But if modem-init is present, firmware-name must not be present.
if:
required:
- modem-init
then:
not:
required:
- firmware-name

additionalProperties: false

examples:
Expand Down

0 comments on commit 9d26628

Please sign in to comment.