Skip to content

Commit

Permalink
GFS2: Merge ordered and writeback writepage
Browse files Browse the repository at this point in the history
The writepages function was recently merged between writeback
and ordered mode. This completes the change by doing the same
with writepage. The remaining differences in writepage were
left over from some earlier time and not actually doing anything
useful.

Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>
  • Loading branch information
Steven Whitehouse committed Aug 27, 2013
1 parent 7286b31 commit 9d35814
Showing 1 changed file with 4 additions and 31 deletions.
35 changes: 4 additions & 31 deletions fs/gfs2/aops.c
Original file line number Diff line number Diff line change
Expand Up @@ -122,14 +122,13 @@ static int gfs2_writepage_common(struct page *page,
}

/**
* gfs2_writeback_writepage - Write page for writeback mappings
* gfs2_writepage - Write page for writeback mappings
* @page: The page
* @wbc: The writeback control
*
*/

static int gfs2_writeback_writepage(struct page *page,
struct writeback_control *wbc)
static int gfs2_writepage(struct page *page, struct writeback_control *wbc)
{
int ret;

Expand All @@ -140,32 +139,6 @@ static int gfs2_writeback_writepage(struct page *page,
return nobh_writepage(page, gfs2_get_block_noalloc, wbc);
}

/**
* gfs2_ordered_writepage - Write page for ordered data files
* @page: The page to write
* @wbc: The writeback control
*
*/

static int gfs2_ordered_writepage(struct page *page,
struct writeback_control *wbc)
{
struct inode *inode = page->mapping->host;
struct gfs2_inode *ip = GFS2_I(inode);
int ret;

ret = gfs2_writepage_common(page, wbc);
if (ret <= 0)
return ret;

if (!page_has_buffers(page)) {
create_empty_buffers(page, inode->i_sb->s_blocksize,
(1 << BH_Dirty)|(1 << BH_Uptodate));
}
gfs2_page_add_databufs(ip, page, 0, inode->i_sb->s_blocksize-1);
return block_write_full_page(page, gfs2_get_block_noalloc, wbc);
}

/**
* __gfs2_jdata_writepage - The core of jdata writepage
* @page: The page to write
Expand Down Expand Up @@ -1107,7 +1080,7 @@ int gfs2_releasepage(struct page *page, gfp_t gfp_mask)
}

static const struct address_space_operations gfs2_writeback_aops = {
.writepage = gfs2_writeback_writepage,
.writepage = gfs2_writepage,
.writepages = gfs2_writepages,
.readpage = gfs2_readpage,
.readpages = gfs2_readpages,
Expand All @@ -1123,7 +1096,7 @@ static const struct address_space_operations gfs2_writeback_aops = {
};

static const struct address_space_operations gfs2_ordered_aops = {
.writepage = gfs2_ordered_writepage,
.writepage = gfs2_writepage,
.writepages = gfs2_writepages,
.readpage = gfs2_readpage,
.readpages = gfs2_readpages,
Expand Down

0 comments on commit 9d35814

Please sign in to comment.