Skip to content

Commit

Permalink
misc: hpilo: rename device creation loop variable
Browse files Browse the repository at this point in the history
In `ilo_probe()`, the loop variable `minor` isn't really the minor
device number, it's the channel or slot number.  Rename it to `slot` for
consistency.

Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Link: https://lore.kernel.org/r/20240119132032.106053-3-abbotti@mev.co.uk
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Ian Abbott authored and Greg Kroah-Hartman committed Jan 31, 2024
1 parent 1c9a697 commit 9d5043d
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions drivers/misc/hpilo.c
Original file line number Diff line number Diff line change
Expand Up @@ -770,7 +770,7 @@ static void ilo_remove(struct pci_dev *pdev)
static int ilo_probe(struct pci_dev *pdev,
const struct pci_device_id *ent)
{
int devnum, minor, start, error = 0;
int devnum, slot, start, error = 0;
struct ilo_hwinfo *ilo_hw;

if (pci_match_id(ilo_blacklist, pdev)) {
Expand Down Expand Up @@ -839,11 +839,11 @@ static int ilo_probe(struct pci_dev *pdev,
goto remove_isr;
}

for (minor = 0 ; minor < max_ccb; minor++) {
for (slot = 0; slot < max_ccb; slot++) {
struct device *dev;
dev = device_create(&ilo_class, &pdev->dev,
MKDEV(ilo_major, start + minor), NULL,
"hpilo!d%dccb%d", devnum, minor);
MKDEV(ilo_major, start + slot), NULL,
"hpilo!d%dccb%d", devnum, slot);
if (IS_ERR(dev))
dev_err(&pdev->dev, "Could not create files\n");
}
Expand Down

0 comments on commit 9d5043d

Please sign in to comment.