Skip to content

Commit

Permalink
net: tls: fix async vs NIC crypto offload
Browse files Browse the repository at this point in the history
commit c706b2b upstream.

When NIC takes care of crypto (or the record has already
been decrypted) we forget to update darg->async. ->async
is supposed to mean whether record is async capable on
input and whether record has been queued for async crypto
on output.

Reported-by: Gal Pressman <gal@nvidia.com>
Fixes: 3547a1f ("tls: rx: use async as an in-out argument")
Tested-by: Gal Pressman <gal@nvidia.com>
Link: https://lore.kernel.org/r/20220425233309.344858-1-kuba@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Jakub Kicinski authored and Greg Kroah-Hartman committed Mar 6, 2024
1 parent 68dbe92 commit 9d59322
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions net/tls/tls_sw.c
Original file line number Diff line number Diff line change
Expand Up @@ -1568,6 +1568,7 @@ static int decrypt_skb_update(struct sock *sk, struct sk_buff *skb,

if (tlm->decrypted) {
darg->zc = false;
darg->async = false;
return 0;
}

Expand All @@ -1578,6 +1579,7 @@ static int decrypt_skb_update(struct sock *sk, struct sk_buff *skb,
if (err > 0) {
tlm->decrypted = 1;
darg->zc = false;
darg->async = false;
goto decrypt_done;
}
}
Expand Down

0 comments on commit 9d59322

Please sign in to comment.