Skip to content

Commit

Permalink
[MTD] [NAND] Fix refactoring of EDB7312 hwcontrol function.
Browse files Browse the repository at this point in the history
The patch ensures that the current code (kernel 2.6.22) uses the bits
like the code prior to the refactoring. The variable "bits" is employed
in a useful way now.

Signed-off-by: Roland Stigge <stigge@antcom.de>
Signed-off-by: David Woodhouse <dwmw2@infradead.org>
  • Loading branch information
Roland Stigge authored and David Woodhouse committed Aug 2, 2007
1 parent 47af05d commit 9d7b4b5
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions drivers/mtd/nand/edb7312.c
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ static struct mtd_partition partition_info[] = {
/*
* hardware specific access to control-lines
*
* NAND_NCE: bit 0 -> bit 7
* NAND_NCE: bit 0 -> bit 6 (bit 7 = 1)
* NAND_CLE: bit 1 -> bit 4
* NAND_ALE: bit 2 -> bit 5
*/
Expand All @@ -83,12 +83,12 @@ static void ep7312_hwcontrol(struct mtd_info *mtd, int cmd, unsigned int ctrl)
struct nand_chip *chip = mtd->priv;

if (ctrl & NAND_CTRL_CHANGE) {
unsigned char bits;
unsigned char bits = 0x80;

bits = (ctrl & (NAND_CLE | NAND_ALE)) << 3;
bits = (ctrl & NAND_NCE) << 7;
bits |= (ctrl & (NAND_CLE | NAND_ALE)) << 3;
bits |= (ctrl & NAND_NCE) ? 0x00 : 0x40;

clps_writeb((clps_readb(ep7312_pxdr) & 0xB0) | 0x10,
clps_writeb((clps_readb(ep7312_pxdr) & 0xF0) | bits,
ep7312_pxdr);
}
if (cmd != NAND_CMD_NONE)
Expand Down

0 comments on commit 9d7b4b5

Please sign in to comment.