Skip to content

Commit

Permalink
drm/mgag200: Don't change unrelated registers during modeset
Browse files Browse the repository at this point in the history
Registers in indices below 0x18 are totally unrelated to modesetting,
so don't write 0's, or anything else into them on modeset. Most of
these registers are hardware cursor related, so this existing code
interferes with hardware cursor development.

Signed-off-by: Christopher Harvey <charvey@matrox.com>
Tested-by: Julia Lemire <jlemire@matrox.com>
Acked-by: Julia Lemire <jlemire@matrox.com>
Acked-by: Mathieu Larouche <mathieu.larouche@matrox.com>
Signed-off-by: Dave Airlie <airlied@redhat.com>
  • Loading branch information
Christopher Harvey authored and Dave Airlie committed May 13, 2013
1 parent b2dfcae commit 9d8aa55
Showing 1 changed file with 1 addition and 5 deletions.
6 changes: 1 addition & 5 deletions drivers/gpu/drm/mgag200/mgag200_mode.c
Original file line number Diff line number Diff line change
Expand Up @@ -832,11 +832,7 @@ static int mga_crtc_mode_set(struct drm_crtc *crtc,


for (i = 0; i < sizeof(dacvalue); i++) {
if ((i <= 0x03) ||
(i == 0x07) ||
(i == 0x0b) ||
(i == 0x0f) ||
((i >= 0x13) && (i <= 0x17)) ||
if ((i <= 0x17) ||
(i == 0x1b) ||
(i == 0x1c) ||
((i >= 0x1f) && (i <= 0x29)) ||
Expand Down

0 comments on commit 9d8aa55

Please sign in to comment.