Skip to content

Commit

Permalink
Revert "usb: gadget: allow to enable legacy drivers without USB_ETH"
Browse files Browse the repository at this point in the history
This reverts commit 7a9618a.

Romain Izard recently reported that commit 7a9618a ended up
allowing every legacy gadget driver to statically linked to the
kernel, however that doesn't work, since only one legacy gadget can be
bound to a controller. Because of that, let's revert the original commit
and fix the problem.

Reported-by: Romain Izard <romain.izard.pro@gmail.com>
Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
  • Loading branch information
Felipe Balbi committed Dec 12, 2017
1 parent 54eed78 commit 9dbe416
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 12 deletions.
4 changes: 2 additions & 2 deletions drivers/usb/gadget/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -508,8 +508,8 @@ choice
controller, and the relevant drivers for each function declared
by the device.

endchoice

source "drivers/usb/gadget/legacy/Kconfig"

endchoice

endif # USB_GADGET
10 changes: 0 additions & 10 deletions drivers/usb/gadget/legacy/Kconfig
Original file line number Diff line number Diff line change
Expand Up @@ -13,14 +13,6 @@
# both kinds of controller can also support "USB On-the-Go" (CONFIG_USB_OTG).
#

menuconfig USB_GADGET_LEGACY
bool "Legacy USB Gadget Support"
help
Legacy USB gadgets are USB gadgets that do not use the USB gadget
configfs interface.

if USB_GADGET_LEGACY

config USB_ZERO
tristate "Gadget Zero (DEVELOPMENT)"
select USB_LIBCOMPOSITE
Expand Down Expand Up @@ -498,5 +490,3 @@ config USB_G_WEBCAM

Say "y" to link the driver statically, or "m" to build a
dynamically linked module called "g_webcam".

endif

0 comments on commit 9dbe416

Please sign in to comment.