Skip to content

Commit

Permalink
media: rc: remove redundant dev_err message
Browse files Browse the repository at this point in the history
devm_ioremap_resource already contains error message, so remove
the redundant dev_err message

Signed-off-by: Ding Xiang <dingxiang@cmss.chinamobile.com>
Signed-off-by: Sean Young <sean@mess.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
  • Loading branch information
Ding Xiang authored and Mauro Carvalho Chehab committed Jun 27, 2019
1 parent b48cb35 commit 9e2e438
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 7 deletions.
4 changes: 1 addition & 3 deletions drivers/media/rc/meson-ir.c
Original file line number Diff line number Diff line change
Expand Up @@ -113,10 +113,8 @@ static int meson_ir_probe(struct platform_device *pdev)

res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
ir->reg = devm_ioremap_resource(dev, res);
if (IS_ERR(ir->reg)) {
dev_err(dev, "failed to map registers\n");
if (IS_ERR(ir->reg))
return PTR_ERR(ir->reg);
}

irq = platform_get_irq(pdev, 0);
if (irq < 0) {
Expand Down
4 changes: 1 addition & 3 deletions drivers/media/rc/mtk-cir.c
Original file line number Diff line number Diff line change
Expand Up @@ -320,10 +320,8 @@ static int mtk_ir_probe(struct platform_device *pdev)

res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
ir->base = devm_ioremap_resource(dev, res);
if (IS_ERR(ir->base)) {
dev_err(dev, "failed to map registers\n");
if (IS_ERR(ir->base))
return PTR_ERR(ir->base);
}

ir->rc = devm_rc_allocate_device(dev, RC_DRIVER_IR_RAW);
if (!ir->rc) {
Expand Down
1 change: 0 additions & 1 deletion drivers/media/rc/sunxi-cir.c
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,6 @@ static int sunxi_ir_probe(struct platform_device *pdev)
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
ir->base = devm_ioremap_resource(dev, res);
if (IS_ERR(ir->base)) {
dev_err(dev, "failed to map registers\n");
ret = PTR_ERR(ir->base);
goto exit_clkdisable_clk;
}
Expand Down

0 comments on commit 9e2e438

Please sign in to comment.