Skip to content

Commit

Permalink
ieee1394: iso and async streams: s/g list fix
Browse files Browse the repository at this point in the history
Torsten Kaiser wrote:
> Looking that calltrace upwards, it seems replacing the
> memset(dma->sglist,...) with sg_init_table(...) would fix the BUG_ON()
> as that inits the SG_MAGIC.

Tested-by: Torsten Kaiser <just.for.lkml@googlemail.com>
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
  • Loading branch information
Jens Axboe authored and Stefan Richter committed Nov 4, 2007
1 parent b4f5550 commit 9e66269
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions drivers/ieee1394/dma.c
Original file line number Diff line number Diff line change
Expand Up @@ -103,8 +103,7 @@ int dma_region_alloc(struct dma_region *dma, unsigned long n_bytes,
goto err;
}

/* just to be safe - this will become unnecessary once sglist->address goes away */
memset(dma->sglist, 0, dma->n_pages * sizeof(*dma->sglist));
sg_init_table(dma->sglist, dma->n_pages);

/* fill scatter/gather list with pages */
for (i = 0; i < dma->n_pages; i++) {
Expand Down

0 comments on commit 9e66269

Please sign in to comment.