Skip to content

Commit

Permalink
USB: ti_usb_3410_5052: fix dynamic-id matching
Browse files Browse the repository at this point in the history
commit 1fad564 upstream.

The driver failed to take the dynamic ids into account when determining
the device type and therefore all devices were detected as 2-port
devices when using the dynamic-id interface.

Match on the usb-serial-driver field instead of doing redundant id-table
searches.

Reported-by: Anders Hammarquist <iko@iko.pp.se>
Signed-off-by: Johan Hovold <jhovold@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
  • Loading branch information
Johan Hovold authored and Ben Hutchings committed Aug 2, 2013
1 parent bbacf54 commit 9e91b41
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/usb/serial/ti_usb_3410_5052.c
Original file line number Diff line number Diff line change
Expand Up @@ -408,7 +408,7 @@ static int ti_startup(struct usb_serial *serial)
usb_set_serial_data(serial, tdev);

/* determine device type */
if (usb_match_id(serial->interface, ti_id_table_3410))
if (serial->type == &ti_1port_device)
tdev->td_is_3410 = 1;
dbg("%s - device type is %s", __func__,
tdev->td_is_3410 ? "3410" : "5052");
Expand Down

0 comments on commit 9e91b41

Please sign in to comment.