Skip to content

Commit

Permalink
Merge branch 'nfp-support-corigine-pcie-vendor-id'
Browse files Browse the repository at this point in the history
Simon Horman says:

====================
nfp: support Corigine PCIE vendor ID

Historically the nfp driver has supported NFP chips with Netronome's
PCIE vendor ID. This patch extends the driver to also support NFP
chips, which at this point are assumed to be otherwise identical from
a software perspective, that have Corigine's PCIE vendor ID (0x1da8).

This patchset begins by cleaning up strings to make them:
* Vendor neutral for the NFP chip
* Relate to Corigine for the driver itself

It then adds support to the driver for the Corigine's PCIE vendor ID
====================

Link: https://lore.kernel.org/r/20220508173816.476357-1-simon.horman@corigine.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
  • Loading branch information
Jakub Kicinski committed May 10, 2022
2 parents 5bcfeb6 + 299ba7a commit 9eab75d
Show file tree
Hide file tree
Showing 5 changed files with 57 additions and 21 deletions.
38 changes: 29 additions & 9 deletions drivers/net/ethernet/netronome/nfp/nfp_main.c
Original file line number Diff line number Diff line change
Expand Up @@ -33,22 +33,38 @@
static const char nfp_driver_name[] = "nfp";

static const struct pci_device_id nfp_pci_device_ids[] = {
{ PCI_VENDOR_ID_NETRONOME, PCI_DEVICE_ID_NETRONOME_NFP3800,
{ PCI_VENDOR_ID_NETRONOME, PCI_DEVICE_ID_NFP3800,
PCI_VENDOR_ID_NETRONOME, PCI_ANY_ID,
PCI_ANY_ID, 0, NFP_DEV_NFP3800,
},
{ PCI_VENDOR_ID_NETRONOME, PCI_DEVICE_ID_NETRONOME_NFP4000,
{ PCI_VENDOR_ID_NETRONOME, PCI_DEVICE_ID_NFP4000,
PCI_VENDOR_ID_NETRONOME, PCI_ANY_ID,
PCI_ANY_ID, 0, NFP_DEV_NFP6000,
},
{ PCI_VENDOR_ID_NETRONOME, PCI_DEVICE_ID_NETRONOME_NFP5000,
{ PCI_VENDOR_ID_NETRONOME, PCI_DEVICE_ID_NFP5000,
PCI_VENDOR_ID_NETRONOME, PCI_ANY_ID,
PCI_ANY_ID, 0, NFP_DEV_NFP6000,
},
{ PCI_VENDOR_ID_NETRONOME, PCI_DEVICE_ID_NETRONOME_NFP6000,
{ PCI_VENDOR_ID_NETRONOME, PCI_DEVICE_ID_NFP6000,
PCI_VENDOR_ID_NETRONOME, PCI_ANY_ID,
PCI_ANY_ID, 0, NFP_DEV_NFP6000,
},
{ PCI_VENDOR_ID_CORIGINE, PCI_DEVICE_ID_NFP3800,
PCI_VENDOR_ID_CORIGINE, PCI_ANY_ID,
PCI_ANY_ID, 0, NFP_DEV_NFP3800,
},
{ PCI_VENDOR_ID_CORIGINE, PCI_DEVICE_ID_NFP4000,
PCI_VENDOR_ID_CORIGINE, PCI_ANY_ID,
PCI_ANY_ID, 0, NFP_DEV_NFP6000,
},
{ PCI_VENDOR_ID_CORIGINE, PCI_DEVICE_ID_NFP5000,
PCI_VENDOR_ID_CORIGINE, PCI_ANY_ID,
PCI_ANY_ID, 0, NFP_DEV_NFP6000,
},
{ PCI_VENDOR_ID_CORIGINE, PCI_DEVICE_ID_NFP6000,
PCI_VENDOR_ID_CORIGINE, PCI_ANY_ID,
PCI_ANY_ID, 0, NFP_DEV_NFP6000,
},
{ 0, } /* Required last entry. */
};
MODULE_DEVICE_TABLE(pci, nfp_pci_device_ids);
Expand Down Expand Up @@ -681,8 +697,10 @@ static int nfp_pci_probe(struct pci_dev *pdev,
struct nfp_pf *pf;
int err;

if (pdev->vendor == PCI_VENDOR_ID_NETRONOME &&
pdev->device == PCI_DEVICE_ID_NETRONOME_NFP6000_VF)
if ((pdev->vendor == PCI_VENDOR_ID_NETRONOME ||
pdev->vendor == PCI_VENDOR_ID_CORIGINE) &&
(pdev->device == PCI_DEVICE_ID_NFP3800_VF ||
pdev->device == PCI_DEVICE_ID_NFP6000_VF))
dev_warn(&pdev->dev, "Binding NFP VF device to the NFP PF driver, the VF driver is called 'nfp_netvf'\n");

dev_info = &nfp_dev_info[pci_id->driver_data];
Expand Down Expand Up @@ -865,7 +883,9 @@ static int __init nfp_main_init(void)
{
int err;

pr_info("%s: NFP PCIe Driver, Copyright (C) 2014-2017 Netronome Systems\n",
pr_info("%s: NFP PCIe Driver, Copyright (C) 2014-2020 Netronome Systems\n",
nfp_driver_name);
pr_info("%s: NFP PCIe Driver, Copyright (C) 2021-2022 Corigine Inc.\n",
nfp_driver_name);

nfp_net_debugfs_create();
Expand Down Expand Up @@ -909,6 +929,6 @@ MODULE_FIRMWARE("netronome/nic_AMDA0099-0001_2x10.nffw");
MODULE_FIRMWARE("netronome/nic_AMDA0099-0001_2x25.nffw");
MODULE_FIRMWARE("netronome/nic_AMDA0099-0001_1x10_1x25.nffw");

MODULE_AUTHOR("Netronome Systems <oss-drivers@netronome.com>");
MODULE_AUTHOR("Corigine, Inc. <oss-drivers@corigine.com>");
MODULE_LICENSE("GPL");
MODULE_DESCRIPTION("The Netronome Flow Processor (NFP) driver.");
MODULE_DESCRIPTION("The Network Flow Processor (NFP) driver.");
2 changes: 1 addition & 1 deletion drivers/net/ethernet/netronome/nfp/nfp_net_common.c
Original file line number Diff line number Diff line change
Expand Up @@ -1984,7 +1984,7 @@ static const struct udp_tunnel_nic_info nfp_udp_tunnels = {
*/
void nfp_net_info(struct nfp_net *nn)
{
nn_info(nn, "Netronome NFP-6xxx %sNetdev: TxQs=%d/%d RxQs=%d/%d\n",
nn_info(nn, "NFP-6xxx %sNetdev: TxQs=%d/%d RxQs=%d/%d\n",
nn->dp.is_vf ? "VF " : "",
nn->dp.num_tx_rings, nn->max_tx_rings,
nn->dp.num_rx_rings, nn->max_rx_rings);
Expand Down
12 changes: 10 additions & 2 deletions drivers/net/ethernet/netronome/nfp/nfp_netvf_main.c
Original file line number Diff line number Diff line change
Expand Up @@ -38,14 +38,22 @@ struct nfp_net_vf {
static const char nfp_net_driver_name[] = "nfp_netvf";

static const struct pci_device_id nfp_netvf_pci_device_ids[] = {
{ PCI_VENDOR_ID_NETRONOME, PCI_DEVICE_ID_NETRONOME_NFP3800_VF,
{ PCI_VENDOR_ID_NETRONOME, PCI_DEVICE_ID_NFP3800_VF,
PCI_VENDOR_ID_NETRONOME, PCI_ANY_ID,
PCI_ANY_ID, 0, NFP_DEV_NFP3800_VF,
},
{ PCI_VENDOR_ID_NETRONOME, PCI_DEVICE_ID_NETRONOME_NFP6000_VF,
{ PCI_VENDOR_ID_NETRONOME, PCI_DEVICE_ID_NFP6000_VF,
PCI_VENDOR_ID_NETRONOME, PCI_ANY_ID,
PCI_ANY_ID, 0, NFP_DEV_NFP6000_VF,
},
{ PCI_VENDOR_ID_CORIGINE, PCI_DEVICE_ID_NFP3800_VF,
PCI_VENDOR_ID_CORIGINE, PCI_ANY_ID,
PCI_ANY_ID, 0, NFP_DEV_NFP3800_VF,
},
{ PCI_VENDOR_ID_CORIGINE, PCI_DEVICE_ID_NFP6000_VF,
PCI_VENDOR_ID_CORIGINE, PCI_ANY_ID,
PCI_ANY_ID, 0, NFP_DEV_NFP6000_VF,
},
{ 0, } /* Required last entry. */
};
MODULE_DEVICE_TABLE(pci, nfp_netvf_pci_device_ids);
Expand Down
18 changes: 9 additions & 9 deletions drivers/net/ethernet/netronome/nfp/nfpcore/nfp6000_pcie.c
Original file line number Diff line number Diff line change
Expand Up @@ -621,13 +621,13 @@ static int enable_bars(struct nfp6000_pcie *nfp, u16 interface)
nfp->dev_info->pcie_expl_offset;

switch (nfp->pdev->device) {
case PCI_DEVICE_ID_NETRONOME_NFP3800:
case PCI_DEVICE_ID_NFP3800:
pf = nfp->pdev->devfn & 7;
nfp->iomem.csr = bar->iomem + NFP_PCIE_BAR(pf);
break;
case PCI_DEVICE_ID_NETRONOME_NFP4000:
case PCI_DEVICE_ID_NETRONOME_NFP5000:
case PCI_DEVICE_ID_NETRONOME_NFP6000:
case PCI_DEVICE_ID_NFP4000:
case PCI_DEVICE_ID_NFP5000:
case PCI_DEVICE_ID_NFP6000:
nfp->iomem.csr = bar->iomem + NFP_PCIE_BAR(0);
break;
default:
Expand All @@ -640,12 +640,12 @@ static int enable_bars(struct nfp6000_pcie *nfp, u16 interface)
}

switch (nfp->pdev->device) {
case PCI_DEVICE_ID_NETRONOME_NFP3800:
case PCI_DEVICE_ID_NFP3800:
expl_groups = 1;
break;
case PCI_DEVICE_ID_NETRONOME_NFP4000:
case PCI_DEVICE_ID_NETRONOME_NFP5000:
case PCI_DEVICE_ID_NETRONOME_NFP6000:
case PCI_DEVICE_ID_NFP4000:
case PCI_DEVICE_ID_NFP5000:
case PCI_DEVICE_ID_NFP6000:
expl_groups = 4;
break;
default:
Expand Down Expand Up @@ -1314,7 +1314,7 @@ nfp_cpp_from_nfp6000_pcie(struct pci_dev *pdev, const struct nfp_dev_info *dev_i
int err;

/* Finished with card initialization. */
dev_info(&pdev->dev, "Netronome Flow Processor %s PCIe Card Probe\n",
dev_info(&pdev->dev, "Network Flow Processor %s PCIe Card Probe\n",
dev_info->chip_names);
pcie_print_link_status(pdev);

Expand Down
8 changes: 8 additions & 0 deletions drivers/net/ethernet/netronome/nfp/nfpcore/nfp_dev.h
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,14 @@

#include <linux/types.h>

#define PCI_VENDOR_ID_CORIGINE 0x1da8
#define PCI_DEVICE_ID_NFP3800 0x3800
#define PCI_DEVICE_ID_NFP4000 0x4000
#define PCI_DEVICE_ID_NFP5000 0x5000
#define PCI_DEVICE_ID_NFP6000 0x6000
#define PCI_DEVICE_ID_NFP3800_VF 0x3803
#define PCI_DEVICE_ID_NFP6000_VF 0x6003

enum nfp_dev_id {
NFP_DEV_NFP3800,
NFP_DEV_NFP3800_VF,
Expand Down

0 comments on commit 9eab75d

Please sign in to comment.