Skip to content

Commit

Permalink
tracing: Rename check_ignore_pid() to ignore_this_task()
Browse files Browse the repository at this point in the history
The name "check_ignore_pid" is confusing in trying to figure out if the pid
should be ignored or not. Rename it to "ignore_this_task" which is pretty
straight forward, as a task (not a pid) is passed in, and should if true
should be ignored.

Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
  • Loading branch information
Steven Rostedt committed Apr 19, 2016
1 parent c3b46c7 commit 9ebc57c
Showing 1 changed file with 7 additions and 7 deletions.
14 changes: 7 additions & 7 deletions kernel/trace/trace_events.c
Original file line number Diff line number Diff line change
Expand Up @@ -484,7 +484,7 @@ static int cmp_pid(const void *key, const void *elt)
}

static bool
check_ignore_pid(struct trace_pid_list *filtered_pids, struct task_struct *task)
ignore_this_task(struct trace_pid_list *filtered_pids, struct task_struct *task)
{
pid_t search_pid;
pid_t *pid;
Expand Down Expand Up @@ -517,8 +517,8 @@ event_filter_pid_sched_switch_probe_pre(void *data, bool preempt,
pid_list = rcu_dereference_sched(tr->filtered_pids);

this_cpu_write(tr->trace_buffer.data->ignore_pid,
check_ignore_pid(pid_list, prev) &&
check_ignore_pid(pid_list, next));
ignore_this_task(pid_list, prev) &&
ignore_this_task(pid_list, next));
}

static void
Expand All @@ -531,7 +531,7 @@ event_filter_pid_sched_switch_probe_post(void *data, bool preempt,
pid_list = rcu_dereference_sched(tr->filtered_pids);

this_cpu_write(tr->trace_buffer.data->ignore_pid,
check_ignore_pid(pid_list, next));
ignore_this_task(pid_list, next));
}

static void
Expand All @@ -547,7 +547,7 @@ event_filter_pid_sched_wakeup_probe_pre(void *data, struct task_struct *task)
pid_list = rcu_dereference_sched(tr->filtered_pids);

this_cpu_write(tr->trace_buffer.data->ignore_pid,
check_ignore_pid(pid_list, task));
ignore_this_task(pid_list, task));
}

static void
Expand All @@ -564,7 +564,7 @@ event_filter_pid_sched_wakeup_probe_post(void *data, struct task_struct *task)

/* Set tracing if current is enabled */
this_cpu_write(tr->trace_buffer.data->ignore_pid,
check_ignore_pid(pid_list, current));
ignore_this_task(pid_list, current));
}

static void __ftrace_clear_event_pids(struct trace_array *tr)
Expand Down Expand Up @@ -1561,7 +1561,7 @@ static void ignore_task_cpu(void *data)
mutex_is_locked(&event_mutex));

this_cpu_write(tr->trace_buffer.data->ignore_pid,
check_ignore_pid(pid_list, current));
ignore_this_task(pid_list, current));
}

static ssize_t
Expand Down

0 comments on commit 9ebc57c

Please sign in to comment.