Skip to content

Commit

Permalink
ACPI, x86: Fix extended error log driver to depend on CONFIG_X86_LOCA…
Browse files Browse the repository at this point in the history 
…L_APIC

Randconfig build by Fengguang's robot army reported:

   drivers/built-in.o: In function `extlog_print':
   >> acpi_extlog.c:(.text+0xcc719): undefined reference to `boot_cpu_physical_apicid'

The config had CONFIG_SMP=n so we picked up this definition from:

  <asm/cpu.h>: #define cpu_physical_id(cpu) boot_cpu_physical_apicid

But boot_cpu_physical_apicid is defined in arch/x86/kernel/apic/apic.c
which is only built if CONFIG_X86_LOCAL_APIC=y.

Reported-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Tony Luck <tony.luck@intel.com>
Cc: Chen Gong <gong.chen@linux.intel.com>
Cc: Rafael J. Wysocki <rjw@rjwysocki.net>
Link: http://lkml.kernel.org/r/6be3afdcad7968f7fb7c0b681e547b3e872e44dd.1383947368.git.tony.luck@intel.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
  • Loading branch information
Luck, Tony authored and Ingo Molnar committed Nov 11, 2013
1 parent 0841c04 commit 9ebddac
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/acpi/Kconfig
View file
Original file line number Diff line number Diff line change
Expand Up @@ -374,7 +374,7 @@ source "drivers/acpi/apei/Kconfig"

config ACPI_EXTLOG
tristate "Extended Error Log support"
depends on X86_MCE
depends on X86_MCE && X86_LOCAL_APIC
select EFI
select UEFI_CPER
default n
Expand Down

0 comments on commit 9ebddac

Please sign in to comment.