Skip to content

Commit

Permalink
tty: hvc: Return proper error code from console ->setup() hook
Browse files Browse the repository at this point in the history
For unifying console ->setup() handling, which is poorly documented,
return error code, rather than non-zero arbitrary number.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Petr Mladek <pmladek@suse.com>
Signed-off-by: Petr Mladek <pmladek@suse.com>
Link: https://lore.kernel.org/r/20200618164751.56828-5-andriy.shevchenko@linux.intel.com
  • Loading branch information
Andy Shevchenko authored and Petr Mladek committed Jun 25, 2020
1 parent 8629d27 commit 9f02842
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/tty/hvc/hvsi.c
Original file line number Diff line number Diff line change
Expand Up @@ -1128,7 +1128,7 @@ static int __init hvsi_console_setup(struct console *console, char *options)
int ret;

if (console->index < 0 || console->index >= hvsi_count)
return -1;
return -EINVAL;
hp = &hvsi_ports[console->index];

/* give the FSP a chance to change the baud rate when we re-open */
Expand Down

0 comments on commit 9f02842

Please sign in to comment.