Skip to content

Commit

Permalink
mlxsw: pci: Fix missing error checking
Browse files Browse the repository at this point in the history
I accidentally removed the error checking after issuing the reset.
Restore it.

Fixes: f257c73 ("mlxsw: pci: Add support for new reset flow")
Reported-by: Coverity Scan <scan-admin@coverity.com>
Signed-off-by: Ido Schimmel <idosch@nvidia.com>
Reviewed-by: Jiri Pirko <jiri@nvidia.com>
Signed-off-by: Petr Machata <petrm@nvidia.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Ido Schimmel authored and David S. Miller committed Nov 25, 2023
1 parent 2f3ce7a commit 9f1f611
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions drivers/net/ethernet/mellanox/mlxsw/pci.c
Original file line number Diff line number Diff line change
Expand Up @@ -1561,6 +1561,8 @@ mlxsw_pci_reset(struct mlxsw_pci *mlxsw_pci, const struct pci_device_id *id)
pci_dbg(pdev, "Starting software reset flow\n");
err = mlxsw_pci_reset_sw(mlxsw_pci);
}
if (err)
return err;

err = mlxsw_pci_sys_ready_wait(mlxsw_pci, id, &sys_status);
if (err) {
Expand Down

0 comments on commit 9f1f611

Please sign in to comment.