Skip to content

Commit

Permalink
arm64: dts: r8a7795: Don't disable referenced optional clocks
Browse files Browse the repository at this point in the history
clk_get() on a disabled clock node will return -EPROBE_DEFER, which can
cause drivers to be deferred forever if such clocks are referenced in
their devices' clocks properties.

Update the various disabled external clock nodes to default to a
frequency of 0, but don't disable them, to prevent this.

Reported-by: Jürg Billeter <j@bitron.ch>
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
  • Loading branch information
Geert Uytterhoeven authored and Simon Horman committed Apr 27, 2016
1 parent de5a79f commit 9f33a8a
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 4 deletions.
1 change: 1 addition & 0 deletions arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts
Original file line number Diff line number Diff line change
Expand Up @@ -394,6 +394,7 @@
};

&pcie_bus_clk {
clock-frequency = <100000000>;
status = "okay";
};

Expand Down
5 changes: 1 addition & 4 deletions arch/arm64/boot/dts/renesas/r8a7795.dtsi
Original file line number Diff line number Diff line change
Expand Up @@ -120,23 +120,20 @@
compatible = "fixed-clock";
#clock-cells = <0>;
clock-frequency = <0>;
status = "disabled";
};

/* External SCIF clock - to be overridden by boards that provide it */
scif_clk: scif {
compatible = "fixed-clock";
#clock-cells = <0>;
clock-frequency = <0>;
status = "disabled";
};

/* External PCIe clock - can be overridden by the board */
pcie_bus_clk: pcie_bus {
compatible = "fixed-clock";
#clock-cells = <0>;
clock-frequency = <100000000>;
status = "disabled";
clock-frequency = <0>;
};

soc {
Expand Down

0 comments on commit 9f33a8a

Please sign in to comment.