Skip to content

Commit

Permalink
iommu/vt-d: Fix signedness bug in alloc_irte()
Browse files Browse the repository at this point in the history
"index" needs to be signed for the error handling to work.  I deleted a
little bit of obsolete cruft related to "index" and "start_index" as
well.

Fixes: 360eb3c ('iommu/vt-d: use dedicated bitmap to track remapping entry allocation status')

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Joerg Roedel <joro@8bytes.org>
  • Loading branch information
Dan Carpenter authored and Joerg Roedel committed Jan 9, 2014
1 parent 9bdc531 commit 9f4c744
Showing 1 changed file with 1 addition and 6 deletions.
7 changes: 1 addition & 6 deletions drivers/iommu/intel_irq_remapping.c
Original file line number Diff line number Diff line change
Expand Up @@ -71,18 +71,13 @@ static int alloc_irte(struct intel_iommu *iommu, int irq, u16 count)
struct ir_table *table = iommu->ir_table;
struct irq_2_iommu *irq_iommu = irq_2_iommu(irq);
struct irq_cfg *cfg = irq_get_chip_data(irq);
u16 index, start_index;
unsigned int mask = 0;
unsigned long flags;
int index;

if (!count || !irq_iommu)
return -1;

/*
* start the IRTE search from index 0.
*/
index = start_index = 0;

if (count > 1) {
count = __roundup_pow_of_two(count);
mask = ilog2(count);
Expand Down

0 comments on commit 9f4c744

Please sign in to comment.