Skip to content

Commit

Permalink
powerpc/fsl-corenet: Disable coreint if kexec is enabled
Browse files Browse the repository at this point in the history
Problems have been observed in coreint (EPR) mode if interrupts are
left pending (due to the lack of device quiescence with kdump) after
having tried to deliver to a CPU but unable to deliver due to MSR[EE]
-- interrupts no longer get reliably delivered in the new kernel.  I
tried various ways of fixing it up inside the crash kernel itself, and
none worked (including resetting the entire mpic).  Masking all
interrupts and issuing EOIs in the crashing kernel did help a lot of
the time, but the behavior was not consistent.

Thus, stick to standard IACK mode when kdump is a possibility.

Signed-off-by: Scott Wood <scottwood@freescale.com>
  • Loading branch information
Scott Wood committed Oct 17, 2015
1 parent 01c593d commit 9f640bf
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions arch/powerpc/platforms/85xx/corenet_generic.c
Original file line number Diff line number Diff line change
Expand Up @@ -216,10 +216,12 @@ define_machine(corenet_generic) {
.pcibios_fixup_phb = fsl_pcibios_fixup_phb,
#endif
/*
* Core reset may cause issue if using the proxy mode of MPIC.
* Core reset may cause issues if using the proxy mode of MPIC.
* So, use the mixed mode of MPIC if enabling CPU hotplug.
*
* Likewise, problems have been seen with kexec when coreint is enabled.
*/
#ifdef CONFIG_HOTPLUG_CPU
#if defined(CONFIG_HOTPLUG_CPU) || defined(CONFIG_KEXEC)
.get_irq = mpic_get_irq,
#else
.get_irq = mpic_get_coreint_irq,
Expand Down

0 comments on commit 9f640bf

Please sign in to comment.