Skip to content

Commit

Permalink
ACPICA: OSL: Cleanup the inclusion order of the compiler-specific hea…
Browse files Browse the repository at this point in the history
…ders

ACPICA commit a760a98ec84b1ec782e0bff5f6612af6fb89c10c

Originally compiler specific headers are included by the host-specific
headers. This makes build configuration management very inconvenient. And
many inclusion order issues can be hidden accross different host OSes. It
will then likely that some host builds will be broken just because of
fixing some inclusion order issues for other host builds.

This patch splits the compiler-specific header inclusions out of the
host-specific headers so that compiler-specific inclusion order issues will
not get entangled in the host-specific inclusion orders.

Note that intel compiler defines __GNUC__, so this patch contains special
handling because acintel.h and acgcc.h should be mutual exclusive.

Link: https://github.com/acpica/acpica/commit/a760a98e
Link: https://bugs.acpica.org/show_bug.cgi?id=1303
Signed-off-by: Lv Zheng <lv.zheng@intel.com>
Signed-off-by: Bob Moore <robert.moore@intel.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
  • Loading branch information
Lv Zheng authored and Rafael J. Wysocki committed Aug 13, 2016
1 parent d2d48ea commit 9fa1ceb
Show file tree
Hide file tree
Showing 3 changed files with 17 additions and 8 deletions.
13 changes: 12 additions & 1 deletion include/acpi/platform/acenv.h
Original file line number Diff line number Diff line change
Expand Up @@ -166,10 +166,21 @@
/******************************************************************************
*
* Host configuration files. The compiler configuration files are included
* by the host files.
* first.
*
*****************************************************************************/

#if defined(__GNUC__) && !defined(__INTEL_COMPILER)
#include <acpi/platform/acgcc.h>

#elif defined(_MSC_VER)
#include "acmsvc.h"

#elif defined(__INTEL_COMPILER)
#include "acintel.h"

#endif

#if defined(_LINUX) || defined(__linux__)
#include <acpi/platform/aclinux.h>

Expand Down
8 changes: 5 additions & 3 deletions include/acpi/platform/acenvex.h
Original file line number Diff line number Diff line change
Expand Up @@ -56,9 +56,6 @@
#if defined(_LINUX) || defined(__linux__)
#include <acpi/platform/aclinuxex.h>

#elif defined(WIN32)
#include "acwinex.h"

#elif defined(__DragonFly__)
#include "acdragonflyex.h"

Expand All @@ -72,6 +69,11 @@

#endif

#if defined(_MSC_VER)
#include "acmsvcex.h"

#endif

/*! [End] no source code translation !*/

#endif /* __ACENVEX_H__ */
4 changes: 0 additions & 4 deletions include/acpi/platform/aclinux.h
Original file line number Diff line number Diff line change
Expand Up @@ -215,8 +215,4 @@

#endif /* __KERNEL__ */

/* Linux uses GCC */

#include <acpi/platform/acgcc.h>

#endif /* __ACLINUX_H__ */

0 comments on commit 9fa1ceb

Please sign in to comment.