Skip to content

Commit

Permalink
clocksource: sun5i: Fix of_io_request_and_map error check
Browse files Browse the repository at this point in the history
of_io_request_and map returns an error pointer, but the current code assumes
that on error the returned pointer will be NULL.

Obviously, that makes the check completely useless. Change the test to actually
check for the proper error code.

Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
Link: http://lkml.kernel.org/r/1430579006-32702-6-git-send-email-maxime.ripard@free-electrons.com
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
  • Loading branch information
Maxime Ripard authored and Thomas Gleixner committed May 5, 2015
1 parent bd580e7 commit 9fa8cc0
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/clocksource/timer-sun5i.c
Original file line number Diff line number Diff line change
Expand Up @@ -324,7 +324,7 @@ static void __init sun5i_timer_init(struct device_node *node)
int irq;

timer_base = of_io_request_and_map(node, 0, of_node_full_name(node));
if (!timer_base)
if (IS_ERR(timer_base))
panic("Can't map registers");

irq = irq_of_parse_and_map(node, 0);
Expand Down

0 comments on commit 9fa8cc0

Please sign in to comment.