Skip to content

Commit

Permalink
bpf: Remove unused new_flags in hierarchy_allows_attach()
Browse files Browse the repository at this point in the history
new_flags is unused, remove it.

Signed-off-by: Andrey Ignatov <rdna@fb.com>
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
Acked-by: Martin KaFai Lau <kafai@fb.com>
Link: https://lore.kernel.org/bpf/2c49b30ab750f93cfef04a1e40b097d70c3a39a1.1576741281.git.rdna@fb.com
  • Loading branch information
Andrey Ignatov authored and Alexei Starovoitov committed Dec 20, 2019
1 parent 1020c1f commit 9fab329
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions kernel/bpf/cgroup.c
Original file line number Diff line number Diff line change
Expand Up @@ -103,8 +103,7 @@ static u32 prog_list_length(struct list_head *head)
* if parent has overridable or multi-prog, allow attaching
*/
static bool hierarchy_allows_attach(struct cgroup *cgrp,
enum bpf_attach_type type,
u32 new_flags)
enum bpf_attach_type type)
{
struct cgroup *p;

Expand Down Expand Up @@ -303,7 +302,7 @@ int __cgroup_bpf_attach(struct cgroup *cgrp, struct bpf_prog *prog,
/* invalid combination */
return -EINVAL;

if (!hierarchy_allows_attach(cgrp, type, flags))
if (!hierarchy_allows_attach(cgrp, type))
return -EPERM;

if (!list_empty(progs) && cgrp->bpf.flags[type] != flags)
Expand Down

0 comments on commit 9fab329

Please sign in to comment.