Skip to content

Commit

Permalink
net: strparser: fix strparser sk_user_data check
Browse files Browse the repository at this point in the history
sk_user_data mismatch between what kcm expects (psock) and what strparser expects (strparser).

Queued rx_work, for example calling strp_check_rcv after socket buffer changes, will never complete.

sk_user_data is unused in strparser, so just remove the check.

Signed-off-by: Dave Watson <davejwatson@fb.com>
Acked-by: Tom Herbert <tom@herbertland.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Dave Watson authored and David S. Miller committed Aug 23, 2016
1 parent f1ff866 commit a01512d
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions net/strparser/strparser.c
Original file line number Diff line number Diff line change
Expand Up @@ -390,9 +390,6 @@ static void do_strp_rx_work(struct strparser *strp)
*/
lock_sock(csk);

if (unlikely(csk->sk_user_data != strp))
goto out;

if (unlikely(strp->rx_stopped))
goto out;

Expand Down

0 comments on commit a01512d

Please sign in to comment.