Skip to content

Commit

Permalink
fsl/fman: use resource_size
Browse files Browse the repository at this point in the history
Use resource_size rather than a verbose computation on
the end and start fields.

The semantic patch that makes these changes is as follows:
(http://coccinelle.lip6.fr/)

<smpl>
@@ struct resource ptr; @@
- (ptr.end + 1 - ptr.start)
+ resource_size(&ptr)

@@ struct resource *ptr; @@
- (ptr->end + 1 - ptr->start)
+ resource_size(ptr)
</smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Julia Lawall authored and David S. Miller committed Jan 3, 2020
1 parent 6485f9a commit a02158d
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions drivers/net/ethernet/freescale/fman/mac.c
Original file line number Diff line number Diff line change
Expand Up @@ -692,7 +692,7 @@ static int mac_probe(struct platform_device *_of_dev)

mac_dev->res = __devm_request_region(dev,
fman_get_mem_region(priv->fman),
res.start, res.end + 1 - res.start,
res.start, resource_size(&res),
"mac");
if (!mac_dev->res) {
dev_err(dev, "__devm_request_mem_region(mac) failed\n");
Expand All @@ -701,7 +701,7 @@ static int mac_probe(struct platform_device *_of_dev)
}

priv->vaddr = devm_ioremap(dev, mac_dev->res->start,
mac_dev->res->end + 1 - mac_dev->res->start);
resource_size(mac_dev->res));
if (!priv->vaddr) {
dev_err(dev, "devm_ioremap() failed\n");
err = -EIO;
Expand Down

0 comments on commit a02158d

Please sign in to comment.