Skip to content

Commit

Permalink
powerpc/mm: Add option for non-atomic PTE updates to ppc64
Browse files Browse the repository at this point in the history
ppc32 has it already, add it to ppc64 as a preliminary for adding
support for Book3E 64-bit support

Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
  • Loading branch information
Benjamin Herrenschmidt committed Mar 24, 2009
1 parent ff7c660 commit a033a48
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 1 deletion.
12 changes: 11 additions & 1 deletion arch/powerpc/include/asm/pgtable-ppc64.h
Original file line number Diff line number Diff line change
Expand Up @@ -178,6 +178,7 @@ static inline unsigned long pte_update(struct mm_struct *mm,
pte_t *ptep, unsigned long clr,
int huge)
{
#ifdef PTE_ATOMIC_UPDATES
unsigned long old, tmp;

__asm__ __volatile__(
Expand All @@ -190,7 +191,10 @@ static inline unsigned long pte_update(struct mm_struct *mm,
: "=&r" (old), "=&r" (tmp), "=m" (*ptep)
: "r" (ptep), "r" (clr), "m" (*ptep), "i" (_PAGE_BUSY)
: "cc" );

#else
unsigned long old = pte_val(*ptep);
*ptep = __pte(old & ~clr);
#endif
/* huge pages use the old page table lock */
if (!huge)
assert_pte_locked(mm, addr);
Expand Down Expand Up @@ -278,6 +282,8 @@ static inline void __ptep_set_access_flags(pte_t *ptep, pte_t entry)
unsigned long bits = pte_val(entry) &
(_PAGE_DIRTY | _PAGE_ACCESSED | _PAGE_RW |
_PAGE_EXEC | _PAGE_HWEXEC);

#ifdef PTE_ATOMIC_UPDATES
unsigned long old, tmp;

__asm__ __volatile__(
Expand All @@ -290,6 +296,10 @@ static inline void __ptep_set_access_flags(pte_t *ptep, pte_t entry)
:"=&r" (old), "=&r" (tmp), "=m" (*ptep)
:"r" (bits), "r" (ptep), "m" (*ptep), "i" (_PAGE_BUSY)
:"cc");
#else
unsigned long old = pte_val(*ptep);
*ptep = __pte(old | bits);
#endif
}

#define __HAVE_ARCH_PTE_SAME
Expand Down
2 changes: 2 additions & 0 deletions arch/powerpc/include/asm/pte-hash64.h
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,8 @@
#define _PTEIDX_SECONDARY 0x8
#define _PTEIDX_GROUP_IX 0x7

/* Hash table based platforms need atomic updates of the linux PTE */
#define PTE_ATOMIC_UPDATES 1

#ifdef CONFIG_PPC_64K_PAGES
#include <asm/pte-hash64-64k.h>
Expand Down

0 comments on commit a033a48

Please sign in to comment.