Skip to content

Commit

Permalink
sched/fair: Trigger asym_packing during idle load balance
Browse files Browse the repository at this point in the history
Newly idle load balancing is not always triggered when a CPU becomes idle.
This prevents the scheduler from getting a chance to migrate the task
for asym packing.

Enable active migration during idle load balance too.

Signed-off-by: Vincent Guittot <vincent.guittot@linaro.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: valentin.schneider@arm.com
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Ingo Molnar <mingo@kernel.org>
  • Loading branch information
Vincent Guittot authored and Ingo Molnar committed Jan 27, 2019
1 parent 81a930d commit a062d16
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion kernel/sched/fair.c
Original file line number Diff line number Diff line change
Expand Up @@ -8832,7 +8832,7 @@ static int need_active_balance(struct lb_env *env)
{
struct sched_domain *sd = env->sd;

if (env->idle == CPU_NEWLY_IDLE) {
if (env->idle != CPU_NOT_IDLE) {

/*
* ASYM_PACKING needs to force migrate tasks from busy but
Expand Down

0 comments on commit a062d16

Please sign in to comment.