Skip to content

Commit

Permalink
pppoe: Lacks DST MAC address check
Browse files Browse the repository at this point in the history
A pppoe session is identified by its session ID and MAC address.
Currently pppoe does not check if the received pkg has the correct
MAC address. This is a problem when the eth I/F is in promisc mode
as then any DST MAC address is accepted.

Signed-off-by: Joakim Tjernlund <joakim.tjernlund@transmode.se>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Joakim Tjernlund authored and David S. Miller committed Apr 20, 2015
1 parent 2ab9574 commit a068833
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions drivers/net/ppp/pppoe.c
Original file line number Diff line number Diff line change
Expand Up @@ -380,6 +380,9 @@ static int pppoe_rcv_core(struct sock *sk, struct sk_buff *skb)
* can't change.
*/

if (skb->pkt_type == PACKET_OTHERHOST)
goto abort_kfree;

if (sk->sk_state & PPPOX_BOUND) {
ppp_input(&po->chan, skb);
} else if (sk->sk_state & PPPOX_RELAY) {
Expand Down

0 comments on commit a068833

Please sign in to comment.