Skip to content

Commit

Permalink
soc: qcom: rpmh-rsc: Loop over fewer bits in irq handler
Browse files Browse the repository at this point in the history
readl() returns a u32, and BITS_PER_LONG is different on 32-bit vs.
64-bit architectures. Let's loop over the possible bits set in that type
instead of looping over more bits than we ever may need to.

Cc: Maulik Shah <mkshah@codeaurora.org>
Reviewed-by: Douglas Anderson <dianders@chromium.org>
Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>
Signed-off-by: Stephen Boyd <swboyd@chromium.org>
Link: https://lore.kernel.org/r/20200521060425.24285-3-swboyd@chromium.org
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
  • Loading branch information
Stephen Boyd authored and Bjorn Andersson committed Mar 12, 2021
1 parent 814a0d4 commit a077662
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/soc/qcom/rpmh-rsc.c
Original file line number Diff line number Diff line change
Expand Up @@ -392,7 +392,7 @@ static irqreturn_t tcs_tx_done(int irq, void *p)

irq_status = readl_relaxed(drv->tcs_base + RSC_DRV_IRQ_STATUS);

for_each_set_bit(i, &irq_status, BITS_PER_LONG) {
for_each_set_bit(i, &irq_status, BITS_PER_TYPE(u32)) {
req = get_req_from_tcs(drv, i);
if (!req) {
WARN_ON(1);
Expand Down

0 comments on commit a077662

Please sign in to comment.