Skip to content

Commit

Permalink
video: fbdev: pxa3xx-gcu: Fix integer overflow in pxa3xx_gcu_write
Browse files Browse the repository at this point in the history
In pxa3xx_gcu_write, a count parameter of type size_t is passed to words of
type int.  Then, copy_from_user() may cause a heap overflow because it is used
as the third argument of copy_from_user().

Signed-off-by: Hyunwoo Kim <imv4bel@gmail.com>
Signed-off-by: Helge Deller <deller@gmx.de>
  • Loading branch information
Hyunwoo Kim authored and Helge Deller committed Jun 20, 2022
1 parent 267173c commit a09d2d0
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/video/fbdev/pxa3xx-gcu.c
Original file line number Diff line number Diff line change
Expand Up @@ -381,7 +381,7 @@ pxa3xx_gcu_write(struct file *file, const char *buff,
struct pxa3xx_gcu_batch *buffer;
struct pxa3xx_gcu_priv *priv = to_pxa3xx_gcu_priv(file);

int words = count / 4;
size_t words = count / 4;

/* Does not need to be atomic. There's a lock in user space,
* but anyhow, this is just for statistics. */
Expand Down

0 comments on commit a09d2d0

Please sign in to comment.