Skip to content

Commit

Permalink
Merge branch 'pcmcia-next' of git://git.kernel.org/pub/scm/linux/kern…
Browse files Browse the repository at this point in the history
…el/git/brodo/linux

Pull pcmcia updates from Dominik Brodowski:
 "Two minor PCMCIA odd fixes: one replacing zero-length arrays with a
  flexible-array member, and one making a local function static"

* 'pcmcia-next' of git://git.kernel.org/pub/scm/linux/kernel/git/brodo/linux:
  pcmcia: make pccard_loop_tuple() static
  pcmcia: Replace zero-length array with flexible-array
  • Loading branch information
Linus Torvalds committed Jun 4, 2020
2 parents 86c67ce + 46d0797 commit a0a4d17
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 12 deletions.
6 changes: 0 additions & 6 deletions drivers/pcmcia/cs_internal.h
Original file line number Diff line number Diff line change
Expand Up @@ -164,12 +164,6 @@ int pcmcia_replace_cis(struct pcmcia_socket *s,
int pccard_validate_cis(struct pcmcia_socket *s, unsigned int *count);
int verify_cis_cache(struct pcmcia_socket *s);

int pccard_loop_tuple(struct pcmcia_socket *s, unsigned int function,
cisdata_t code, cisparse_t *parse, void *priv_data,
int (*loop_tuple) (tuple_t *tuple,
cisparse_t *parse,
void *priv_data));

int pccard_get_first_tuple(struct pcmcia_socket *s, unsigned int function,
tuple_t *tuple);

Expand Down
6 changes: 3 additions & 3 deletions drivers/pcmcia/pcmcia_cis.c
Original file line number Diff line number Diff line change
Expand Up @@ -78,9 +78,9 @@ int pccard_read_tuple(struct pcmcia_socket *s, unsigned int function,
* calls the @loop_tuple function for each entry. If the call to @loop_tuple
* returns 0, the loop exits. Returns 0 on success or errorcode otherwise.
*/
int pccard_loop_tuple(struct pcmcia_socket *s, unsigned int function,
cisdata_t code, cisparse_t *parse, void *priv_data,
int (*loop_tuple) (tuple_t *tuple,
static int pccard_loop_tuple(struct pcmcia_socket *s, unsigned int function,
cisdata_t code, cisparse_t *parse, void *priv_data,
int (*loop_tuple) (tuple_t *tuple,
cisparse_t *parse,
void *priv_data))
{
Expand Down
6 changes: 3 additions & 3 deletions include/pcmcia/cistpl.h
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ typedef struct cistpl_funcid_t {

typedef struct cistpl_funce_t {
u_char type;
u_char data[0];
u_char data[];
} cistpl_funce_t;

/*======================================================================
Expand Down Expand Up @@ -255,7 +255,7 @@ typedef struct cistpl_data_serv_t {
u_char escape;
u_char encrypt;
u_char misc_features;
u_char ccitt_code[0];
u_char ccitt_code[];
} cistpl_data_serv_t;

typedef struct cistpl_fax_serv_t {
Expand All @@ -265,7 +265,7 @@ typedef struct cistpl_fax_serv_t {
u_char encrypt;
u_char features_0;
u_char features_1;
u_char ccitt_code[0];
u_char ccitt_code[];
} cistpl_fax_serv_t;

typedef struct cistpl_voice_serv_t {
Expand Down

0 comments on commit a0a4d17

Please sign in to comment.