Skip to content

Commit

Permalink
net: phylink: constify fwnode arguments
Browse files Browse the repository at this point in the history
Both phylink_create() and phylink_fwnode_phy_connect() do not modify
the fwnode argument that they are passed, so lets constify these.

Reviewed-by: Simon Horman <simon.horman@corigine.com>
Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Russell King (Oracle) authored and David S. Miller committed May 13, 2023
1 parent 144470c commit a0b7955
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 9 deletions.
11 changes: 6 additions & 5 deletions drivers/net/phy/phylink.c
Original file line number Diff line number Diff line change
Expand Up @@ -708,7 +708,7 @@ static int phylink_validate(struct phylink *pl, unsigned long *supported,
}

static int phylink_parse_fixedlink(struct phylink *pl,
struct fwnode_handle *fwnode)
const struct fwnode_handle *fwnode)
{
struct fwnode_handle *fixed_node;
bool pause, asym_pause, autoneg;
Expand Down Expand Up @@ -819,7 +819,8 @@ static int phylink_parse_fixedlink(struct phylink *pl,
return 0;
}

static int phylink_parse_mode(struct phylink *pl, struct fwnode_handle *fwnode)
static int phylink_parse_mode(struct phylink *pl,
const struct fwnode_handle *fwnode)
{
struct fwnode_handle *dn;
const char *managed;
Expand Down Expand Up @@ -1441,7 +1442,7 @@ static void phylink_fixed_poll(struct timer_list *t)
static const struct sfp_upstream_ops sfp_phylink_ops;

static int phylink_register_sfp(struct phylink *pl,
struct fwnode_handle *fwnode)
const struct fwnode_handle *fwnode)
{
struct sfp_bus *bus;
int ret;
Expand Down Expand Up @@ -1480,7 +1481,7 @@ static int phylink_register_sfp(struct phylink *pl,
* must use IS_ERR() to check for errors from this function.
*/
struct phylink *phylink_create(struct phylink_config *config,
struct fwnode_handle *fwnode,
const struct fwnode_handle *fwnode,
phy_interface_t iface,
const struct phylink_mac_ops *mac_ops)
{
Expand Down Expand Up @@ -1809,7 +1810,7 @@ EXPORT_SYMBOL_GPL(phylink_of_phy_connect);
* Returns 0 on success or a negative errno.
*/
int phylink_fwnode_phy_connect(struct phylink *pl,
struct fwnode_handle *fwnode,
const struct fwnode_handle *fwnode,
u32 flags)
{
struct fwnode_handle *phy_fwnode;
Expand Down
9 changes: 5 additions & 4 deletions include/linux/phylink.h
Original file line number Diff line number Diff line change
Expand Up @@ -568,16 +568,17 @@ void phylink_generic_validate(struct phylink_config *config,
unsigned long *supported,
struct phylink_link_state *state);

struct phylink *phylink_create(struct phylink_config *, struct fwnode_handle *,
phy_interface_t iface,
const struct phylink_mac_ops *mac_ops);
struct phylink *phylink_create(struct phylink_config *,
const struct fwnode_handle *,
phy_interface_t,
const struct phylink_mac_ops *);
void phylink_destroy(struct phylink *);
bool phylink_expects_phy(struct phylink *pl);

int phylink_connect_phy(struct phylink *, struct phy_device *);
int phylink_of_phy_connect(struct phylink *, struct device_node *, u32 flags);
int phylink_fwnode_phy_connect(struct phylink *pl,
struct fwnode_handle *fwnode,
const struct fwnode_handle *fwnode,
u32 flags);
void phylink_disconnect_phy(struct phylink *);

Expand Down

0 comments on commit a0b7955

Please sign in to comment.