Skip to content

Commit

Permalink
staging: vc04_services: Delete unnecessary NULL check
Browse files Browse the repository at this point in the history
The "state" pointer points to an offset in the middle of the "mgmt"
struct so it can't possibly be NULL.  And also we dereferenced it on the
line before.  So this NULL check is pointless.  Delete it.

Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Stefan Wahren <wahrenst@gmx.net>
Reviewed-by: Umang Jain <umang.jain@ideasonboard.com>
Link: https://lore.kernel.org/r/526ec2ff-6277-4d5d-b2d9-63b087a97c7c@moroto.mountain
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Dan Carpenter authored and Greg Kroah-Hartman committed May 4, 2024
1 parent 62cbabc commit a0e244e
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions drivers/staging/vc04_services/interface/vchiq_arm/vchiq_dev.c
Original file line number Diff line number Diff line change
Expand Up @@ -1170,11 +1170,6 @@ static int vchiq_open(struct inode *inode, struct file *file)

dev_dbg(state->dev, "arm: vchiq open\n");

if (!state) {
dev_err(state->dev, "arm: vchiq has no connection to VideoCore\n");
return -ENOTCONN;
}

instance = kzalloc(sizeof(*instance), GFP_KERNEL);
if (!instance)
return -ENOMEM;
Expand Down

0 comments on commit a0e244e

Please sign in to comment.