Skip to content

Commit

Permalink
drm/amdkfd: validate pdd where it acquired first
Browse files Browse the repository at this point in the history
Currently pdd is validate after dereferencing it, which is
not correct, Thus validate pdd before its first use.

Signed-off-by: Maninder Singh <maninder1.s@samsung.com>
Signed-off-by: Oded Gabbay <oded.gabbay@gmail.com>
  • Loading branch information
Maninder Singh authored and Oded Gabbay committed Jul 9, 2015
1 parent d770e55 commit a0f6744
Showing 1 changed file with 7 additions and 2 deletions.
9 changes: 7 additions & 2 deletions drivers/gpu/drm/amd/amdkfd/kfd_process.c
Original file line number Diff line number Diff line change
@@ -420,6 +420,12 @@ void kfd_unbind_process_from_device(struct kfd_dev *dev, unsigned int pasid)
pqm_uninit(&p->pqm);

pdd = kfd_get_process_device_data(dev, p);

if (!pdd) {
mutex_unlock(&p->mutex);
return;
}

if (pdd->reset_wavefronts) {
dbgdev_wave_reset_wavefronts(pdd->dev, p);
pdd->reset_wavefronts = false;
@@ -431,8 +437,7 @@ void kfd_unbind_process_from_device(struct kfd_dev *dev, unsigned int pasid)
* We don't call amd_iommu_unbind_pasid() here
* because the IOMMU called us.
*/
if (pdd)
pdd->bound = false;
pdd->bound = false;

mutex_unlock(&p->mutex);
}

0 comments on commit a0f6744

Please sign in to comment.