Skip to content

Commit

Permalink
power: supply: ab8500: Remove flush_scheduled_work() call.
Browse files Browse the repository at this point in the history
It seems to me that ab8500 driver is using dedicated workqueues and
is not calling schedule{,_delayed}_work{,_on}(). Then, there will be
no work to flush using flush_scheduled_work().

Signed-off-by: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
  • Loading branch information
Tetsuo Handa authored and Sebastian Reichel committed Jul 16, 2022
1 parent 13a4223 commit a1124c8
Show file tree
Hide file tree
Showing 4 changed files with 0 additions and 5 deletions.
1 change: 0 additions & 1 deletion drivers/power/supply/ab8500_btemp.c
Original file line number Diff line number Diff line change
Expand Up @@ -697,7 +697,6 @@ static void ab8500_btemp_unbind(struct device *dev, struct device *master,

/* Delete the work queue */
destroy_workqueue(di->btemp_wq);
flush_scheduled_work();
}

static const struct component_ops ab8500_btemp_component_ops = {
Expand Down
1 change: 0 additions & 1 deletion drivers/power/supply/ab8500_chargalg.c
Original file line number Diff line number Diff line change
Expand Up @@ -1769,7 +1769,6 @@ static void ab8500_chargalg_unbind(struct device *dev, struct device *master,

/* Delete the work queue */
destroy_workqueue(di->chargalg_wq);
flush_scheduled_work();
}

static const struct component_ops ab8500_chargalg_component_ops = {
Expand Down
2 changes: 0 additions & 2 deletions drivers/power/supply/ab8500_charger.c
Original file line number Diff line number Diff line change
Expand Up @@ -3377,8 +3377,6 @@ static void ab8500_charger_unbind(struct device *dev)
/* Delete the work queue */
destroy_workqueue(di->charger_wq);

flush_scheduled_work();

/* Unbind fg, btemp, algorithm */
component_unbind_all(dev, di);
}
Expand Down
1 change: 0 additions & 1 deletion drivers/power/supply/ab8500_fg.c
Original file line number Diff line number Diff line change
Expand Up @@ -3227,7 +3227,6 @@ static int ab8500_fg_remove(struct platform_device *pdev)
struct ab8500_fg *di = platform_get_drvdata(pdev);

destroy_workqueue(di->fg_wq);
flush_scheduled_work();
component_del(&pdev->dev, &ab8500_fg_component_ops);
list_del(&di->node);
ab8500_fg_sysfs_exit(di);
Expand Down

0 comments on commit a1124c8

Please sign in to comment.