Skip to content

Commit

Permalink
selftests: net: devlink_port_split: check devlink returned an element…
Browse files Browse the repository at this point in the history
… before dereferencing it

And thus avoid a Python stacktrace:

~/linux/tools/testing/selftests/net$ ./devlink_port_split.py
Traceback (most recent call last):
  File "/home/linux/tools/testing/selftests/net/./devlink_port_split.py",
line 277, in <module> main()
  File "/home/linux/tools/testing/selftests/net/./devlink_port_split.py",
line 242, in main
    dev = list(devs.keys())[0]
IndexError: list index out of range

Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Paolo Pisati authored and David S. Miller committed Jun 28, 2021
1 parent b856150 commit a118ff6
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions tools/testing/selftests/net/devlink_port_split.py
Original file line number Diff line number Diff line change
Expand Up @@ -239,6 +239,9 @@ def main(cmdline=None):
assert stderr == ""

devs = json.loads(stdout)['dev']
if len(devs.keys()) == 0:
print("no devlink device found")
sys.exit(1)
dev = list(devs.keys())[0]

cmd = "devlink dev show %s" % dev
Expand Down

0 comments on commit a118ff6

Please sign in to comment.