Skip to content

Commit

Permalink
[PATCH] __group_complete_signal: remove bogus BUG_ON
Browse files Browse the repository at this point in the history
Commit e56d090

   [PATCH] RCU signal handling

made this BUG_ON() unsafe. This code runs under ->siglock,
while switch_exec_pids() takes tasklist_lock.

Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
  • Loading branch information
Oleg Nesterov authored and Linus Torvalds committed Apr 11, 2006
1 parent 2514395 commit a145410
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion kernel/signal.c
Original file line number Diff line number Diff line change
Expand Up @@ -868,7 +868,6 @@ __group_complete_signal(int sig, struct task_struct *p)
if (t == NULL)
/* restart balancing at this thread */
t = p->signal->curr_target = p;
BUG_ON(t->tgid != p->tgid);

while (!wants_signal(sig, t)) {
t = next_thread(t);
Expand Down

0 comments on commit a145410

Please sign in to comment.