Skip to content

Commit

Permalink
staging: lustre: lnet: lnet: fix error return code
Browse files Browse the repository at this point in the history
Return a negative error code on failure.

A simplified version of the semantic match that finds this problem is as
follows: (http://coccinelle.lip6.fr/)

// <smpl>
@@
identifier ret; expression e1,e2;
@@
(
if (\(ret < 0\|ret != 0\))
 { ... return ret; }
|
ret = 0
)
... when != ret = e1
    when != &ret
*if(...)
{
  ... when != ret = e2
      when forall
 return ret;
}
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Julia Lawall authored and Greg Kroah-Hartman committed Apr 5, 2015
1 parent b183c11 commit a18ac31
Showing 1 changed file with 6 additions and 2 deletions.
8 changes: 6 additions & 2 deletions drivers/staging/lustre/lnet/lnet/api-ni.c
Original file line number Diff line number Diff line change
Expand Up @@ -650,15 +650,19 @@ lnet_prepare(lnet_pid_t requested_pid)

recs = lnet_res_containers_create(LNET_COOKIE_TYPE_ME, LNET_FL_MAX_MES,
sizeof(lnet_me_t));
if (recs == NULL)
if (recs == NULL) {
rc = -ENOMEM;
goto failed;
}

the_lnet.ln_me_containers = recs;

recs = lnet_res_containers_create(LNET_COOKIE_TYPE_MD, LNET_FL_MAX_MDS,
sizeof(lnet_libmd_t));
if (recs == NULL)
if (recs == NULL) {
rc = -ENOMEM;
goto failed;
}

the_lnet.ln_md_containers = recs;

Expand Down

0 comments on commit a18ac31

Please sign in to comment.