Skip to content

Commit

Permalink
sched/wait: Collapse __wait_event_interruptible_lock_irq_timeout()
Browse files Browse the repository at this point in the history
Reduce macro complexity by using the new ___wait_event() helper.
No change in behaviour, identical generated code.

Reviewed-by: Oleg Nesterov <oleg@redhat.com>
Signed-off-by: Peter Zijlstra <peterz@infradead.org>
Link: http://lkml.kernel.org/r/20131002092528.759956109@infradead.org
Signed-off-by: Ingo Molnar <mingo@kernel.org>
  • Loading branch information
Peter Zijlstra authored and Ingo Molnar committed Oct 4, 2013
1 parent 8fbd88f commit a1dc685
Showing 1 changed file with 6 additions and 19 deletions.
25 changes: 6 additions & 19 deletions include/linux/wait.h
Original file line number Diff line number Diff line change
Expand Up @@ -763,25 +763,12 @@ do { \
__ret; \
})

#define __wait_event_interruptible_lock_irq_timeout(wq, condition, \
lock, ret) \
do { \
DEFINE_WAIT(__wait); \
\
for (;;) { \
prepare_to_wait(&wq, &__wait, TASK_INTERRUPTIBLE); \
if (___wait_cond_timeout(condition, ret)) \
break; \
if (signal_pending(current)) { \
ret = -ERESTARTSYS; \
break; \
} \
spin_unlock_irq(&lock); \
ret = schedule_timeout(ret); \
spin_lock_irq(&lock); \
} \
finish_wait(&wq, &__wait); \
} while (0)
#define __wait_event_interruptible_lock_irq_timeout(wq, condition, lock, ret) \
___wait_event(wq, ___wait_cond_timeout(condition, ret), \
TASK_INTERRUPTIBLE, 0, ret, \
spin_unlock_irq(&lock); \
ret = schedule_timeout(ret); \
spin_lock_irq(&lock));

/**
* wait_event_interruptible_lock_irq_timeout - sleep until a condition gets true or a timeout elapses.
Expand Down

0 comments on commit a1dc685

Please sign in to comment.