Skip to content

Commit

Permalink
irqchip/bcm2836: Use a more generic memory barrier call
Browse files Browse the repository at this point in the history
dsb() requires an argument on arm64, so we needed to add "sy".
Instead, take this opportunity to switch to the same smp_wmb() call
that gic uses for its IPIs.  This is a less strong barrier than we
were doing before (dmb(ishst) compared to dsb(sy)), but it seems to be
the correct one.

Signed-off-by: Eric Anholt <eric@anholt.net>
Acked-by: Stephen Warren <swarren@wwwdotorg.org>
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
  • Loading branch information
Eric Anholt authored and Marc Zyngier committed May 11, 2016
1 parent cb290d8 commit a1dcbd1
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/irqchip/irq-bcm2836.c
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,7 @@ static void bcm2836_arm_irqchip_send_ipi(const struct cpumask *mask,
* Ensure that stores to normal memory are visible to the
* other CPUs before issuing the IPI.
*/
dsb();
smp_wmb();

for_each_cpu(cpu, mask) {
writel(1 << ipi, mailbox0_base + 16 * cpu);
Expand Down

0 comments on commit a1dcbd1

Please sign in to comment.